Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rpm packagers #1339

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Adding rpm packagers #1339

merged 3 commits into from
Oct 10, 2024

Conversation

djpolygon
Copy link
Contributor

Description

Added rpm packaging for arm and x86 builds
Added checksums
Added profiles for rpm builds using no arch( including pbss profiles )
Dependent on existing PR merge: #1311

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • [x ] New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • [x ] I have added at least 2 reviewer or the whole pos-v1 team
  • [ x] I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • [ x] I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

Manual tests

Tested on arm64 and x86 nodes with rpm and each profile

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.47%. Comparing base (bd5ed4c) to head (2778f66).
Report is 25 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1339   +/-   ##
=======================================
  Coverage   52.47%   52.47%           
=======================================
  Files         739      739           
  Lines      122398   122407    +9     
=======================================
+ Hits        64225    64237   +12     
+ Misses      54195    54181   -14     
- Partials     3978     3989   +11     
Flag Coverage Δ
52.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33 marcello33 requested a review from a team October 3, 2024 05:23
@djpolygon djpolygon changed the base branch from master to develop October 8, 2024 18:41
@djpolygon djpolygon changed the base branch from develop to v1.5.0-candidate October 9, 2024 14:50
@djpolygon djpolygon merged commit bfede06 into v1.5.0-candidate Oct 10, 2024
11 of 12 checks passed
@djpolygon djpolygon deleted the djpolygon/rpm_packaging branch October 10, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants