Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/cli: use fixed the bug caused by fillBigInt and FillTime.Duration functions #474

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

pratikspatil024
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #474 (e19cb58) into develop (6e8428b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #474      +/-   ##
===========================================
+ Coverage    56.93%   56.97%   +0.04%     
===========================================
  Files          607      607              
  Lines        69899    69899              
===========================================
+ Hits         39794    39823      +29     
+ Misses       26697    26674      -23     
+ Partials      3408     3402       -6     
Impacted Files Coverage Δ
internal/cli/server/config_legacy.go 33.33% <100.00%> (ø)
accounts/keystore/watch.go 90.69% <0.00%> (-4.66%) ⬇️
les/distributor.go 79.68% <0.00%> (-2.35%) ⬇️
les/vflux/client/serverpool.go 76.76% <0.00%> (-1.66%) ⬇️
rpc/client.go 83.72% <0.00%> (-1.17%) ⬇️
consensus/ethash/consensus.go 40.21% <0.00%> (-1.07%) ⬇️
eth/protocols/snap/sync.go 71.72% <0.00%> (-0.16%) ⬇️
core/blockchain.go 59.55% <0.00%> (+0.08%) ⬆️
core/tx_pool.go 71.48% <0.00%> (+0.13%) ⬆️
eth/downloader/skeleton.go 76.96% <0.00%> (+0.50%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8428b...e19cb58. Read the comment docs.

@pratikspatil024 pratikspatil024 changed the title Fixed the bug caused by fillBigInt and FillTime.Duration functions internal/cli: use fixed the bug caused by fillBigInt and FillTime.Duration functions Jul 29, 2022
@pratikspatil024 pratikspatil024 merged commit b64af9b into develop Jul 29, 2022
@pratikspatil024 pratikspatil024 deleted the fix-configfile-bug branch July 29, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants