Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🚧 dynamic leverage modal #380

Conversation

arshad-rao-deriv
Copy link

Changes:

Please include a summary of the change and which issue is fixed below:

  • Added dynamic leverage content to the jurisdiction modal

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@coveralls
Copy link

coveralls commented Jul 21, 2023

Pull Request Test Coverage Report for Build 5659450247

  • 27 of 29 (93.1%) changed or added relevant lines in 11 files are covered.
  • 88 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 8.864%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/cfd/src/Containers/jurisdiction-modal/jurisdiction-modal-content-wrapper.tsx 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/cfd/src/Containers/jurisdiction-modal/jurisdiction-modal-content-wrapper.tsx 1 0%
packages/p2p/src/constants/api-error-codes.js 1 50.0%
packages/p2p/src/constants/buy-sell.js 1 50.0%
packages/p2p/src/constants/floating-rate.js 1 50.0%
packages/p2p/src/constants/my-profile-tabs.js 1 50.0%
packages/p2p/src/constants/order-list.js 1 50.0%
packages/cfd/dist/cfd/js/JurisdictionModal.js 41 0%
packages/core/dist/cfd/js/JurisdictionModal.js 41 0%
Totals Coverage Status
Change from base Build 5516330688: 0.02%
Covered Lines: 8594
Relevant Lines: 81421

💛 - Coveralls

@matin-deriv matin-deriv merged commit a37bb26 into matin-deriv:dynamic_leverage Jul 26, 2023
1 check passed
@github-actions
Copy link

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants