Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log message about generating script #60

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

davidbuzinski
Copy link
Contributor

@davidbuzinski davidbuzinski commented May 8, 2024

Remove "Successfully generated script" message from the log. This is an implementation detail and clutters up the logs of our other actions.

@mcafaro
Copy link
Member

mcafaro commented May 8, 2024

Don't we still have the "Generate script" fold? I believe the "Successfully generated script" message shows within that fold.
Screenshot 2024-05-08 at 3 31 32 PM
Seems like we should just remove the entire fold if we're going to remove anything.

@mcafaro
Copy link
Member

mcafaro commented May 8, 2024

Should we also consider silencing the executed run-matlab-command invocation?

Screenshot 2024-05-08 at 3 45 31 PM

It could be useful for debugging but I'm not sure anyone outside of this team could make sense of what it is doing.

@davidbuzinski davidbuzinski merged commit 444020c into main May 9, 2024
1 check passed
@davidbuzinski davidbuzinski deleted the remove-script-log branch May 9, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants