Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff instead of flake8. #15

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Use ruff instead of flake8. #15

merged 2 commits into from
Dec 21, 2022

Conversation

clokep
Copy link
Member

@clokep clokep commented Dec 21, 2022

@clokep clokep marked this pull request as ready for review December 21, 2022 12:54
@clokep clokep requested a review from a team as a code owner December 21, 2022 12:54
@clokep clokep mentioned this pull request Dec 21, 2022
Merged
reivilibre
reivilibre approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering whether this should be in a v2 release?
Other repos will need updating so they install ruff and have the ruff config anyway...

@clokep
Copy link
Member Author

clokep commented Dec 21, 2022

Wondering whether this should be in a v2 release? Other repos will need updating so they install ruff and have the ruff config anyway...

That was my thought? I think if we did a v1.1 or whatever they would start using it automatically.

@clokep clokep changed the base branch from release/v1 to release/v2 December 21, 2022 16:45
@clokep
Copy link
Member Author

clokep commented Dec 21, 2022

Re-targeted this to a new release/v2 branch.

@clokep clokep merged commit 6f6bb21 into release/v2 Dec 21, 2022
@clokep clokep deleted the clokep/ruff branch December 21, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivilibre reivilibre reivilibre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @reivilibre