mitmproxy addon: refactor the callback addon #100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst debugging duplicate OTK upload tests, I noticed that some requests were being tarpitted when they should not have been.
It turns out this was due to the
callback
addon itself not handling concurrent request/responses very well. To fix this, useaiohttp
as per https://github.com/mitmproxy/mitmproxy/blob/main/examples/addons/nonblocking.pyThis also adds tests which just test the callback addon itself, which will eventually fix #3.
Longer term, the
status_code
addon will be obsoleted by thecallback
addon because it will sprout the ability to modify the HTTP response.