Fix chicken/egg problem with resolve_branch #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
resolve_branch.shnow to figure out which branch of each repository to use. Great!However,
resolve_branch.shitself is inside the complement-crypto repository. When CI runs from rust/JS SDK, they will useMATCHING_BRANCHfor complement-crypto. This then tries to runresolve_branch.shto figure out which branch this relates to.. except the script doesn't exist yet as it hasn't been downloaded.For now, we will always use the
mainversion ofresolve_branch.sh, breaking the cycle.