Add TestDelayedInviteResponse #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `InviteUser` to accomodate this.
This was referenced Jun 28, 2024
1 task
bnjbvr
pushed a commit
to matrix-org/matrix-rust-sdk
that referenced
this pull request
Jul 10, 2024
This is needed to prevent the race condition where the invite request finished, the `/sync` one didn't fetch the new membership event yet and we send a message in the room. This message won't be encrypted for the newly invited user and will result in an UTD. I added a new integration test and I can confirm this [complement-crypto test](matrix-org/complement-crypto#98) now passes instead of being skipped. Fixes #3622. --- * fix(sdk): force room member reload after inviting a user This is needed to prevent the race condition where the invite request finished, the `/sync` one didn't fetch the new membership event yet and we send a message in the room. This message won't be encrypted for the newly invited user and will result in an UTD. * Use `room.mark_members_missing()` instead, add integration test * Abort syncing before the test ends * Resolve nit: else after a return * Fix race condition where bob may try to join the room before the invite is received * Remove double sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InviteUserto accomodate this.Implements and fixes #97