Add request query parameters to Complement request debug logs #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `COMPLEMENT_DEBUG=1`, here is the terminal output: Before: ``` msc2716_test.go:899: Making POST request to http://localhost:57176/_matrix/client/unstable/org.matrix.msc2716/rooms/%21WfOaOcxJTCHBxspVgq:hs1/batch_send msc2716_test.go:899: Request body: {"events":[{"content":{"body":"Historical 0 (batch=0)","msgtype":"m.text","org.matrix.msc2716.historical":true},"origin_server_ts":1638404618714,"sender":"@maria:hs1","type":"m.room.message"}],"state_events_at_start":[{"content":{"displayname":"some-display-name-for-@maria:hs1","membership":"join"},"origin_server_ts":1638404618714,"sender":"@maria:hs1","state_key":"@maria:hs1","type":"m.room.member"}]} ``` After: ``` msc2716_test.go:899: Making POST request to http://localhost:57160/_matrix/client/unstable/org.matrix.msc2716/rooms/%21KblUOBFIMMmAVoZnpQ:hs1/batch_send?prev_event_id=%241GidKbmhon-1habkcZokuhcjjvcLLQ5xq2FoVHrdk1E msc2716_test.go:899: Request body: {"events":[{"content":{"body":"Historical 0 (batch=0)","msgtype":"m.text","org.matrix.msc2716.historical":true},"origin_server_ts":1638404572878,"sender":"@maria:hs1","type":"m.room.message"}],"state_events_at_start":[{"content":{"displayname":"some-display-name-for-@maria:hs1","membership":"join"},"origin_server_ts":1638404572878,"sender":"@maria:hs1","state_key":"@maria:hs1","type":"m.room.member"}]} ```
|
Is the difference just the |
MadLittleMods
commented
Dec 2, 2021
| @@ -332,7 +332,7 @@ func (c *CSAPI) DoFunc(t *testing.T, method string, paths []string, opts ...Requ | |||
| } | |||
| // debug log the request | |||
| if c.Debug { | |||
| t.Logf("Making %s request to %s", method, reqURL) | |||
| t.Logf("Making %s request to %s", method, req.URL) | |||
| contentType := req.Header.Get("Content-Type") | |||
There was a problem hiding this comment.
Is the difference just the
?prev_event_id=%241GidKbmhon-1habkcZokuhcjjvcLLQ5xq2FoVHrdk1Eon the first line? Or does the second line also differ?
Just the first line
kegsay
approved these changes
Dec 17, 2021
|
Thanks @kegsay 🐤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add request query parameters to Complement request debug logs (
COMPLEMENT_DEBUG=1), https://github.com/matrix-org/complement/blob/master/ONBOARDING.md#i-think-complement-is-doing-something-weird-can-i-get-more-logsBefore:
After:
Split out from #214