Add a test testing that an m.login.password flow is available on /deactivate
#453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
commented
Aug 22, 2022
DMRobertson
reviewed
Aug 23, 2022
erikjohnston
approved these changes
Sep 6, 2022
| return | ||
| } | ||
| if stageName == "m.login.password" { | ||
| foundPasswordStage = true |
There was a problem hiding this comment.
We should break from the outer loop here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would have caught matrix-org/synapse#13560 before it was too late.
I intend to also copy this test for other endpoints that use user-interactive authentication.