-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster room joins: Add abandoned join tests for device list tracking #476
Merged
erikjohnston
merged 8 commits into
main
from
squah/faster_room_joins_device_list_tracking_incoming_2
Oct 13, 2022
Merged
Faster room joins: Add abandoned join tests for device list tracking #476
erikjohnston
merged 8 commits into
main
from
squah/faster_room_joins_device_list_tracking_incoming_2
Oct 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squahtx
changed the base branch from
main
to
squah/faster_room_joins_device_list_tracking_incoming_1
September 23, 2022 18:29
squahtx
force-pushed
the
squah/faster_room_joins_device_list_tracking_incoming_2
branch
from
September 23, 2022 18:45
625a9ed
to
c53dda4
Compare
squahtx
force-pushed
the
squah/faster_room_joins_device_list_tracking_incoming_1
branch
from
September 23, 2022 18:45
7526731
to
58dfb70
Compare
This was referenced Sep 23, 2022
Base automatically changed from
squah/faster_room_joins_device_list_tracking_incoming_1
to
main
September 29, 2022 13:42
squahtx
force-pushed
the
squah/faster_room_joins_device_list_tracking_incoming_2
branch
from
September 29, 2022 13:44
c53dda4
to
e65bbfd
Compare
richvdh
reviewed
Sep 29, 2022
This was referenced Sep 30, 2022
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
richvdh
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
erikjohnston
deleted the
squah/faster_room_joins_device_list_tracking_incoming_2
branch
October 13, 2022 16:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tests device list tracking when a partial state room is left
before the partial state join completes. Leaving a partial state room
is not currently implemented in Synapse.
Built on top of #475.