Change tests to accomodate non blocking regular sync #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
DMRobertson
approved these changes
Jan 17, 2023
DMRobertson
approved these changes
Jan 17, 2023
DMRobertson
suggested changes
Jan 18, 2023
There was a problem hiding this comment.
I think we're missing a test case here.
Suppose that we
- we an do incremental, non-lazy sync, getting since_token
1. - we partially join a room.
- we incremental, nonlazy sync from since_token
1and get since_token2.- The response here should not include the room. Is this tested?
- someone sends a message to the room.
- We incremental, nonlazy sync from since_token
2and get since_token3.- The response here should not include the room. Is this tested?
- The resync completes.
- We incremental, nonlazy sync from since_token
3and get since_token4. - The response here should include the room. I think this is tested?
- We incremental, nonlazy sync from since_token
(I think in this diff we only cover partial joins with an initial, nonlazy sync?)
DMRobertson
reviewed
Jan 19, 2023
|
|
||
| // initial sync shouldn't include the room yet, but still return immediatly | ||
| response, nextBatch := alice.MustSync(t, client.SyncReq{ | ||
| TimeoutMillis: "10000", |
There was a problem hiding this comment.
I'm not sure this adds anything since MustSync uses a timeout of 1000 by default:
complement/internal/client/client.go
Lines 307 to 309 in 0af85cf
I also think I got myself confused when writing up the comment last night.
I've had a go at this in #588.
There was a problem hiding this comment.
MV: this isn't addressing the comment of dmr above, this is about the notifier changes (see synapse PR)
|
Superseded by #588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.