Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore presence updates in test #590

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Ignore presence updates in test #590

merged 1 commit into from
Jan 20, 2023

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Jan 20, 2023 •
edited
Loading

Otherwise the test fails if the server receives a presence update during the partial join

@erikjohnston erikjohnston requested review from a team as code owners January 20, 2023 16:42
DMRobertson
DMRobertson approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also be fine with func(e gomatrixserverlib.EDU) {} 🤷

@erikjohnston erikjohnston merged commit 45d8ae3 into main Jan 20, 2023
@erikjohnston erikjohnston deleted the erikj/ignore_presence branch January 20, 2023 17:04
@DMRobertson DMRobertson mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @DMRobertson