Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests for leaves during a partial state resync #617

Merged
merged 13 commits into from
Feb 28, 2023
Merged

More tests for leaves during a partial state resync #617

merged 13 commits into from
Feb 28, 2023

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Feb 17, 2023 •
edited
Loading

@DMRobertson DMRobertson force-pushed the dmr/faster-joins/leave-during-resync branch from e7488d7 to 2291653 Compare February 17, 2023 17:19
@DMRobertson DMRobertson force-pushed the dmr/faster-joins/leave-during-resync branch from 2291653 to 52925fd Compare February 17, 2023 17:26
@DMRobertson DMRobertson changed the title WIP: more tests for leaves during resync More tests for leaves during a partial state resync Feb 17, 2023
@DMRobertson DMRobertson marked this pull request as ready for review February 17, 2023 17:32
@DMRobertson DMRobertson requested review from a team and kegsay as code owners February 17, 2023 17:32
@DMRobertson DMRobertson force-pushed the dmr/faster-joins/leave-during-resync branch from 52925fd to dcf42fb Compare February 17, 2023 17:55
@DMRobertson DMRobertson requested a review from H-Shay February 28, 2023 13:27
H-Shay
H-Shay approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@H-Shay H-Shay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding these!

@DMRobertson DMRobertson merged commit 2339a2f into main Feb 28, 2023
@DMRobertson DMRobertson deleted the dmr/faster-joins/leave-during-resync branch February 28, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H-Shay H-Shay H-Shay approved these changes

@kegsay kegsay Awaiting requested review from kegsay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faster joins: Handle leaving a room while re-syncing state
2 participants
@DMRobertson @H-Shay