Tests for transaction ID semantics #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughns
force-pushed
the
hughns/txnid-semantics
branch
2 times, most recently
from
16054c8 to
49d0556
Compare
hughns
changed the title
kegsay
requested changes
Mar 6, 2023
Co-authored-by: kegsay <kegsay@gmail.com>
hughns
force-pushed
the
hughns/txnid-semantics
branch
from
4ff84ab to
b6e1929
Compare
hughns
force-pushed
the
hughns/txnid-semantics
branch
from
12ca5a1 to
67f7d14
Compare
Closed
DMRobertson
reviewed
Apr 12, 2023
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
DMRobertson
approved these changes
Apr 13, 2023
hughns
added a commit
to sandhose/complement
that referenced
this pull request
Apr 18, 2023
* Test for transaction ID semantics * Update internal/client/client.go Co-authored-by: kegsay <kegsay@gmail.com> * Incorporate review feedback * Refactor for legibility * Clarify that conduit doesn't pass idempotency tests * Apply suggestions from code review Co-authored-by: David Robertson <david.m.robertson1@gmail.com> * Incorporate review feedback --------- Co-authored-by: kegsay <kegsay@gmail.com> Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Client-Server API tests relation to transaction identifiers:
Signed-off-by: Hugh Nimmo-Smith hughns@element.io