Deflake faster joins tests by leaving rooms as part of test cleanup

[squahtx]

Many of the faster joins test flakes are due to the homeserver under
test failing to contact Complement homeservers after they have been
torn down. When this happens, subsequent tests can fail if they use a
Complement homeserver that happens to have the same hostname:port as one
which the homeserver under test has previously marked as offline.

Make the homeserver under test leave rooms at the end of each test, so
that it stops trying to contact the Complement homeservers in the room.

Signed-off-by: Sean Quah seanq@matrix.org

---

Reviewable commit by commit.

NB: you can tease out the flakes by forcing Complement to reuse ports whenever possible:

diff --git a/internal/federation/server.go b/internal/federation/server.go
index ed7974d..4c4ccbe 100644
--- a/internal/federation/server.go
+++ b/internal/federation/server.go
@@ -455,7 +455,10 @@ func (s *Server) Listen() (cancel func()) {
        var wg sync.WaitGroup
        wg.Add(1)

-       ln, err := net.Listen("tcp", ":0") //nolint
+       ln, err := net.Listen("tcp", ":63333") //nolint
+       if err != nil {
+               ln, err = net.Listen("tcp", ":63334") //nolint
+       }
        if err != nil {
                s.t.Fatalf("ListenFederationServer: net.Listen failed: %s", err)
        }

[DMRobertson]

LGTM, huge thanks for this!

[DMRobertson]

is this roughly equivalent to del s.pduHandlers[pduHandlerKey] in Python?

[squahtx]

I imagine so

[DMRobertson]

what's the second thing returned by Membership() that gets bound(?) to _ -- a state key?

[squahtx]

It's err (surprise!). membership is "" when there's no such state entry, so I elided the err check.

[squahtx]

Thanks for the review!