Regression test for https://github.com/element-hq/synapse/issues/16928 #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And some drive-by logging improvements, along with a new `ServerRoom.WaiterForEvent(eventID)` function which makes waiting for an event to arrive on the Complement server much much easier to write in code.
|
For linking: element-hq/synapse#16928 |
richvdh
reviewed
Feb 22, 2024
| @@ -25,6 +26,7 @@ import ( | |||
| // - Alice sends event E5 merging the forks. | |||
| // - Alice sync with timeline_limit=1 and a filter that skips E5 | |||
| func TestSyncOmitsStateChangeOnFilteredEvents(t *testing.T) { | |||
| runtime.SkipIf(t, runtime.Dendrite) // S2 is put in the timeline, not state. | |||
There was a problem hiding this comment.
how? does dendrite ignore the limit?
There was a problem hiding this comment.
I don't know, and I don't have the time to diagnose why unfortunately.
erikjohnston
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And some drive-by logging improvements, along with a new
ServerRoom.WaiterForEvent(eventID)function which makes waiting for an event to arrive on the Complement server much much easier to write in code.