Update thumbnail tests to include _matrix/client/v1/media/thumbnail endpoint #728
Conversation
H-Shay
changed the title
| @@ -29,7 +30,10 @@ func TestLocalPngThumbnail(t *testing.T) { | |||
|
|
|||
| uri := alice.UploadContent(t, data.LargePng, fileName, contentType) | |||
|
|
|||
| fetchAndValidateThumbnail(t, alice, uri) | |||
| fetchAndValidateThumbnail(t, alice, uri, false) | |||
There was a problem hiding this comment.
There's nothing wrong with this, but for this and the Remote test, I think it'd be better if the old and new endpoints were separate tests.
Supposing you had a defect in one of the versions of endpoints, you'd want the test results to show which version was working fine and which version wasn't.
Equally, if a new cutting-edge homeserver Syndruit wants to skip implementing the legacy endpoints, they may want to blacklist the tests just for the old version.
I asked in the Complement room and it seems doing this as subtests would work for this and it looks fairly easy to do: seems like you just wrap each part of the test like this:
| fetchAndValidateThumbnail(t, alice, uri, false) | |
| t.Run("unauthenticated", func(t *testing.T) { | |
| fetchAndValidateThumbnail(t, alice, uri, false) | |
| }) |
& similar for the other ones (The string argument to t.Run is a subtest name)
…ticated `_matrix/client/v1/media/thumbnail` endpoint (#17388) [MSC3916](matrix-org/matrix-spec-proposals#3916) added the endpoints `_matrix/federation/v1/media/thumbnail` and the authenticated `_matrix/client/v1/media/thumbnail`. This PR implements those endpoints, along with stabilizing `_matrix/client/v1/media/config` and `_matrix/client/v1/media/preview_url`. Complement tests are at matrix-org/complement#728
|
I've added subtests (thanks for the example!) @reivilibre do you think you could merge this for me if the changes are satisfying? |
No description provided.