Skip tests requiring unauthenticated media on Synapse #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be expected to fail when Synapse enforces authenticated media by default in element-hq/synapse#17889
reivilibre
force-pushed
the
rei/synapse_testcontent_unauthed_skip
branch
from
ad2e34c
to
272068b
Compare
reivilibre
changed the title
reivilibre
force-pushed
the
rei/synapse_testcontent_unauthed_skip
branch
2 times, most recently
from
427320a
to
7431f3d
Compare
reivilibre
force-pushed
the
rei/synapse_testcontent_unauthed_skip
branch
from
7431f3d
to
634b54a
Compare
| @@ -41,6 +41,7 @@ func TestMediaFilenames(t *testing.T) { | |||
| var filename = filename | |||
|
|
|||
| t.Run(fmt.Sprintf("Can download file '%s'", filename), func(t *testing.T) { | |||
| runtime.SkipIf(t, runtime.Synapse) | |||
There was a problem hiding this comment.
I feel like we would want to keep these tests but change them to use authentication?
I think I'd prefer to disable authenticated media when testing with complement rather than not test these paths?
There was a problem hiding this comment.
These tests already exist with authentication, see e.g. L56 for this one
There was a problem hiding this comment.
Can you add a comment or something like "Synapse doesn't support unauthenticated media anymore"?
erikjohnston
approved these changes
Nov 20, 2024
| @@ -41,6 +41,7 @@ func TestMediaFilenames(t *testing.T) { | |||
| var filename = filename | |||
|
|
|||
| t.Run(fmt.Sprintf("Can download file '%s'", filename), func(t *testing.T) { | |||
| runtime.SkipIf(t, runtime.Synapse) | |||
There was a problem hiding this comment.
Can you add a comment or something like "Synapse doesn't support unauthenticated media anymore"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be expected to fail when Synapse enforces authenticated media by default in
element-hq/synapse#17889
Pull Request Checklist
Signed-off-by: Olivier 'reivilibre' oliverw@element.io