Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for m.login.token #2014

Merged
merged 14 commits into from
Feb 10, 2022
Merged

Support for m.login.token #2014

merged 14 commits into from
Feb 10, 2022

Commits on Dec 3, 2021

  1. Add GOPATH to PATH in find-lint.sh.

    The user doesn't necessarily have it in PATH.
    tommie committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    8e085b1 View commit details
    Browse the repository at this point in the history
  2. Refactor LoginTypePassword and Type to support m.login.token and m.lo…

    …gin.sso.
    
    For login token:
    
    * m.login.token will require deleting the token after completeAuth has
      generated an access token, so a cleanup function is returned by
      Type.Login.
    * Allowing different login types will require parsing the /login body
      twice: first to extract the "type" and then the type-specific parsing.
      Thus, we will have to buffer the request JSON in /login, like
      UserInteractive already does.
    
    For SSO:
    
    * NewUserInteractive will have to also use GetAccountByLocalpart. It
      makes more sense to just pass a (narrowed-down) accountDB interface
      to it than adding more function pointers.
    
    Code quality:
    
    * Passing around (and down-casting) interface{} for login request types
      has drawbacks in terms of type-safety, and no inherent benefits. We
      always decode JSON anyway. Hence renaming to Type.LoginFromJSON. Code
      that directly uses LoginTypePassword with parsed data can still use
      Login.
    * Removed a TODO for SSO. This is already tracked in matrix-org#1297.
    * httputil.UnmarshalJSON is useful because it returns a JSONResponse.
    
    This change is intended to have no functional changes.
    tommie committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    6714983 View commit details
    Browse the repository at this point in the history
  3. Support login tokens in User API.

    This adds full lifecycle functions for login tokens: create, query, delete.
    tommie committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    53b5888 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d124de7 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Configuration menu
    Copy the full SHA
    a7d3584 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2021

  1. Fixes for PR review.

    tommie committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    531c805 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1acaae6 View commit details
    Browse the repository at this point in the history
  3. Return event NID from StoreEvent, match PSQL vs SQLite behaviour, t…

    …weak backfill persistence (matrix-org#2071)
    neilalexander authored and tommie committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    d40fefe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1632d28 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Configuration menu
    Copy the full SHA
    4c24e15 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Configuration menu
    Copy the full SHA
    b3292fb View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Configuration menu
    Copy the full SHA
    d7ca02d View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Configuration menu
    Copy the full SHA
    0ab352b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Configuration menu
    Copy the full SHA
    8c8a55d View commit details
    Browse the repository at this point in the history