Complement QoL changes #2663
Merged
Complement QoL changes #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| exec ./dendrite-monolith-server --really-enable-open-registration --tls-cert server.crt --tls-key server.key --config dendrite.yaml -api=${API:-0} |
There was a problem hiding this comment.
CC: @MadLittleMods I think you were complaining about longer build/execution times, iirc?
Yes! Especially with Synapse, matrix-org/synapse#13204
There was a problem hiding this comment.
Looks like Synapse is already PID 1 inside the container and receives the SIGTERM request, so this is not the issue. :/
neilalexander
approved these changes
Aug 22, 2022
…nto s7evink/complement
kegsay
approved these changes
Aug 23, 2022
| ./generate-config -server $SERVER_NAME --ci > dendrite.yaml && \ | ||
| cp /complement/ca/ca.crt /usr/local/share/ca-certificates/ && update-ca-certificates && \ | ||
| ./dendrite-monolith-server --really-enable-open-registration --tls-cert server.crt --tls-key server.key --config dendrite.yaml -api=${API:-0} | ||
| exec ./dendrite-monolith-server --really-enable-open-registration --tls-cert server.crt --tls-key server.key --config dendrite.yaml -api=${API:-0} |
There was a problem hiding this comment.
What difference does this make in practice?
There was a problem hiding this comment.
Seeming 5m 49s on this PR, vs 7m 5s on the last main run.
There was a problem hiding this comment.
For Postgres it's almost 5m faster (8m 19s vs 12m 49s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
keysizeparameter togenerate-keys, so we can use lower sized keys when running in CIexecwhen executingdendrite-monotlith-server, making it PID 1 inside docker, which results in Dendrite actually receiving theSIGTERMsignal send by Docker. (Making it faster when running tests with Complement, as we don't take 10 seconds to timeout)CC: @MadLittleMods I think you were complaining about longer build/execution times, iirc?