refactoring user interactive auth #3380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- making members private as they aren't used outside of the package and in order to protect from concurrent writes - make the mutex protect the sessions only as they are written to concurrently
S7evinK
approved these changes
Sep 13, 2024
Comment on lines
+110
to
+112
|
|
||
| mutex sync.RWMutex | ||
| sessions map[string][]string |
There was a problem hiding this comment.
We've lost the comment for sessions here.
| completed := u.sessions[sessionID] | ||
| u.mutex.RUnlock() | ||
|
|
||
| flows := u.flows |
There was a problem hiding this comment.
Minor nit: No need to create flows when we can use u.flows below directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth.UserInteractiveprivate as they aren't used outside of the package and in order to protect from concurrent writesThis prepares future contributions I plan, in particular adding functionality for multi-stage flows.
Pull Request Checklist