This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Pinecone test image - Explicitly select Alpine golang image #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges, default upstream is now bookworm-based it seems Signed-off-by: Rhea Danzey <rdanzey@element.io>
S7evinK
approved these changes
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed when trying to build the Dendrite Pinecone test image, the build fails due to
apknot being available:Checking out the Docker Hub repo for the
golangimage it looks like this can resovle to1.22-bookworm, so this should ensure we get an Alpine-based image for this build.Pull Request Checklist
Signed-off-by:
Rhea Danzey <rdanzey@element.io>