Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show helpful admin command error if it's a IrcProvisioningError #1702

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

Half-Shot
Copy link
Contributor

We now throw helpful error types when failing to run some provisioning commands but we are still showing "check logs for details". I, like many people get really pissed off when applications make me "check logs for details". For the sake of security this still only emits a error message in the case where we know the type of error.

@Half-Shot Half-Shot requested a review from a team as a code owner April 26, 2023 10:06
Copy link
Member

@AndrewFerr AndrewFerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Half-Shot Half-Shot merged commit e0aa290 into develop Apr 26, 2023
@Half-Shot Half-Shot deleted the hs/nicer-admin-errors branch April 26, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants