This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Don't format within eslint, use prettier standalone instead #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sandhose
commented
Apr 3, 2024
sandhose
commented
- Do not format generated files, as it breaks HMR
- Do not format with eslint, use prettier directly
- Apply prettier to all files in the frontend
This is way faster and prevents unnecessary editor feedback
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
907fac9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f18ab34.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-faster-prettier.matrix-authentication-service-docs.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.