Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TSLint with ESLint #262

Merged
merged 7 commits into from
Jul 28, 2021
Merged

Replace TSLint with ESLint #262

merged 7 commits into from
Jul 28, 2021

Conversation

Half-Shot
Copy link
Collaborator

Most of our bridges have been moved to eslint, but this one got left behind. This PR corrects that injustice. The linting is mostly routine, sorry about the large files.

@Half-Shot Half-Shot requested a review from a team July 28, 2021 13:38
.eslintrc Outdated
{
"types": {
"Object": {
"message": "Avoid using the `Object` type. Did you mean `object`?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'd prefer a proper type or even just Record<string, T|undefined> or Record<string, unknown>.

Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

.eslintrc Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
Half-Shot and others added 2 commits July 28, 2021 16:21
Co-authored-by: Christian Paul <christianp@element.io>
@Half-Shot Half-Shot merged commit e222ccd into develop Jul 28, 2021
@Half-Shot Half-Shot self-assigned this Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants