Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different renderings to topic events #5

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Johennes
Copy link

@Johennes Johennes commented Mar 29, 2022

This extends the m.room.topic event with a new m.topic event that uses the same structure as the m.message event on room messages, thereby allowing for different renderings of room topics.

This largely just copies and renames things from message events. I didn't put any effort into extracting common logic between the two events at this point yet to not over-complicate things.

Marking as draft while I try to actually use this elsewhere.

Relates to: element-hq/element-web#5180
MSC: matrix-org/matrix-spec-proposals#3765

This extends the `m.room.topic` event with a new `m.topic` event that
uses the same structure as the `m.message` event on room messages,
thereby allowing for different renderings of room topics.

Relates to: element-hq/element-web#5180
Signed-off-by: Johannes Marbach <johannesm@element.io>
@Johennes Johennes marked this pull request as draft March 29, 2022 19:36
@ShadowJonathan
Copy link

Does the spec allow this? If not, shouldn't this need an MSC as well?

@Johennes
Copy link
Author

Johennes commented Apr 2, 2022

Does the spec allow this? If not, shouldn't this need an MSC as well?

I was unsure as well when starting but @turt2live said it wouldn't. Essentially this is just using the m.message content defined in MSC1767.

@Johennes
Copy link
Author

Johennes commented Apr 2, 2022

I was unsure as well when starting but @turt2live said it wouldn't.

Ok, looks like this was a misunderstanding on my part. I'll put in a dedicated MSC.

@turt2live
Copy link
Member

To answer the question though: yes, the spec does allow this to happen. Extensions to events are entirely permitted if a client/project wants to use them, though typically they're accompanied by an MSC.

Implementation before MSC is also entirely valid.

@Johennes
Copy link
Author

Johennes commented Apr 3, 2022

MSC3765 has been created. As discussed separately, this is still not intended to be merged yet in order not to complicate future architectural changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants