-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement separate bot users per service #573
Conversation
fd7bee2
to
c65d67f
Compare
Co-authored-by: Christian Paul <christianp@matrix.org>
Higher priority should come first
@Half-Shot (I can't reply to this comment directly for some reason)
It doesn't seem like it can be avoided, since "handing over" a connection really means instantiating it with a different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this – I'm still curious about #573 (comment) though (defering to Half-Shot).
Introduces the ability for Hookshot to present itself as multiple different bots, each of which can handle one or more specific services. This is a pretty fundamental change, and as a result touches almost everywhere.
It should be relatively reviewable by commit, but will require significant testing of different scenarios to make sure things work correctly.
Implementation
Fundamentally, this is breaking an assumption throughout the codebase that there is one global bot. The implications are:
Connections
However, this does not mean connections are tied to a specific bot user.
We need to choose the right bot for a connection, but this is done at runtime based on which bots are in the room (again prioritizing service bots).
Fixes #436