Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SP2: Adding Rooms to Spaces #5230 #1366

Merged
merged 2 commits into from
Feb 17, 2022
Merged

SP2: Adding Rooms to Spaces #5230 #1366

merged 2 commits into from
Feb 17, 2022

Conversation

gileluard
Copy link
Contributor

@gileluard
SP2: Adding Rooms to Spaces #5230
9e39af7 
- MXSpace: added canAddRoom() method
pixlwave
pixlwave approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style nit pick, otherwise looks good to me

MatrixSDK/Space/MXSpace.swift Outdated Show resolved Hide resolved
@gileluard @pixlwave
Update MatrixSDK/Space/MXSpace.swift
46b933c 
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
@gileluard gileluard merged commit 42f3a10 into gil/SP1_space_creation Feb 17, 2022
@gileluard gileluard deleted the gil/5230_SP2-Adding_Rooms_to_Spaces branch February 17, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gileluard @pixlwave