Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty pagination end token on timeline end reached #1508

Merged

Conversation

aringenbach
Copy link
Contributor

Fixes element-hq/element-ios#6347

Required since this change: matrix-org/synapse#12903

@aringenbach aringenbach requested review from a team and stefanceriu and removed request for a team June 27, 2022 16:03
@codecov-commenter
Copy link

Codecov Report

Merging #1508 (3ac7461) into develop (77f0799) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #1508   +/-   ##
========================================
  Coverage    11.67%   11.67%           
========================================
  Files          507      507           
  Lines        83158    83158           
  Branches     35521    35521           
========================================
+ Hits          9708     9711    +3     
+ Misses       73092    73089    -3     
  Partials       358      358           
Impacted Files Coverage Δ
...xSDK/Data/EventTimeline/Room/MXRoomEventTimeline.m 0.00% <0.00%> (ø)
MatrixSDK/Utils/MXHTTPClient.m 30.39% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f0799...3ac7461. Read the comment docs.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@aringenbach aringenbach merged commit f377f65 into develop Jun 28, 2022
@aringenbach aringenbach deleted the aringenbach/6347_handle_empty_pagination_end_token branch June 28, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite pagination on newly created room
3 participants