Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors with details in analytics #1517

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Log errors with details in analytics #1517

merged 3 commits into from
Jul 11, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Jul 11, 2022

Enabling analytics tracking for MXLog.error, where previously only MXLog.failure where tracked. To limit the amount of noise that would result from tracking errors with variables in the string we are only tracking those errors that manually specify a separate details dictionary. This will be changed in the future to either log all errors by default or convert them all to detail-based events

@Anderas Anderas requested review from a team and gileluard and removed request for a team July 11, 2022 09:34
@codecov-commenter
Copy link

Codecov Report

Merging #1517 (14428dd) into develop (da888f1) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff            @@
##           develop    #1517   +/-   ##
========================================
  Coverage    11.67%   11.67%           
========================================
  Files          507      507           
  Lines        83204    83238   +34     
  Branches     35536    35544    +8     
========================================
+ Hits          9711     9719    +8     
- Misses       73135    73161   +26     
  Partials       358      358           
Impacted Files Coverage Δ
...Data/Store/MXRealmCryptoStore/MXRealmCryptoStore.m 15.37% <0.00%> (-0.12%) ⬇️
MatrixSDK/Data/Store/MXFileStore/MXFileStore.m 18.01% <0.00%> (-0.14%) ⬇️
MatrixSDK/Utils/MXLog.h 40.00% <0.00%> (-10.00%) ⬇️
MatrixSDK/Utils/MXLogObjcWrapper.m 33.33% <0.00%> (ø)
MatrixSDK/Utils/MXLog.swift 62.26% <66.66%> (+6.59%) ⬆️
MatrixSDKTests/MXHTTPAdditionalHeadersUnitTests.m 76.08% <0.00%> (-8.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da888f1...14428dd. Read the comment docs.

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Anderas Anderas merged commit 9e43bf3 into develop Jul 11, 2022
@Anderas Anderas deleted the andy/sentry_error branch July 11, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants