Upgrade minimum iOS and OSX deployment target #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team and
paleksandrs
and removed request for
a team
Anderas
changed the title
Codecov ReportBase: 37.03% // Head: 12.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1574 +/- ##
============================================
- Coverage 37.03% 12.48% -24.56%
============================================
Files 521 521
Lines 85000 85023 +23
Branches 37538 36203 -1335
============================================
- Hits 31477 10612 -20865
- Misses 52561 74025 +21464
+ Partials 962 386 -576
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
paleksandrs
approved these changes
Sep 16, 2022
Anderas
force-pushed
the
andy/os_version
branch
from
159d43b
to
dfcbe70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element iOS targets iOS 14 as a minimum whereas the SDK was several versions behind, making it not possible to use Swift concurrency without @available flags. Increasing the iOS and OSX deployment targets to 13 and 10.15 respectively lets us remove these conditionals