Refactor verification manager, requests, transactions #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/verification_refactor
branch
from
7909054
to
34f883d
Compare
Anderas
requested review from
a team and
gileluard
and removed request for
a team
Codecov ReportBase: 13.48% // Head: 13.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1599 +/- ##
===========================================
- Coverage 13.48% 13.48% -0.01%
===========================================
Files 541 541
Lines 86699 86711 +12
Branches 36833 36840 +7
===========================================
Hits 11693 11693
- Misses 74564 74576 +12
Partials 442 442
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Anderas
force-pushed
the
andy/verification_refactor
branch
from
34f883d
to
ee35c54
Compare
Incoming verification requests with Crypto V2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn
MXKeyVerificationManagerinto a protocol and rename all existing objective-c implementations toMXLegacy...variants. This is to make Crypto V2 verification api safer.