Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log decryption errors separately with Crypto V2 #1632

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Nov 11, 2022

Log separate errors based on the type of DecryptionError so that it is easier to distinguish and monitor unrelated failure reasons in sentry

@Anderas Anderas requested review from a team, gileluard, aringenbach and stefanceriu and removed request for a team, gileluard and aringenbach November 11, 2022 10:32
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 36.22% // Head: 36.26% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (d0f40f4) compared to base (d70c5af).
Patch coverage: 38.20% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1632      +/-   ##
===========================================
+ Coverage    36.22%   36.26%   +0.03%     
===========================================
  Files          582      582              
  Lines        92316    92408      +92     
  Branches     40130    40163      +33     
===========================================
+ Hits         33444    33508      +64     
- Misses       57872    57900      +28     
  Partials      1000     1000              
Impacted Files Coverage Δ
...trixSDK/Crypto/CrossSigning/MXCrossSigningV2.swift 21.25% <0.00%> (ø)
...trixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift 0.00% <0.00%> (ø)
MatrixSDK/Crypto/MXCryptoV2.swift 0.81% <0.00%> (+<0.01%) ⬆️
MatrixSDK/Utils/Logs/MXAnalyticsDestination.swift 36.11% <0.00%> (ø)
...s/Crypto/CryptoMachine/MXCryptoProtocolStubs.swift 51.31% <0.00%> (ø)
...pto/KeyBackup/Engine/MXCryptoKeyBackupEngine.swift 47.85% <11.11%> (-1.06%) ⬇️
...o/Algorithms/RoomEvent/MXRoomEventDecryption.swift 57.07% <28.04%> (-11.77%) ⬇️
MatrixSDK/MXSession.m 39.90% <83.33%> (-0.36%) ⬇️
MatrixSDK/Crypto/Data/MXMegolmSessionData.m 76.71% <91.66%> (+2.51%) ⬆️
...chine/MXEventDecryptionResult+DecryptedEvent.swift 84.61% <100.00%> (-3.62%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Anderas Anderas merged commit 3fea0a8 into develop Nov 11, 2022
@Anderas Anderas deleted the andy/crypto_errors branch November 11, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants