Setup cross-signing even without auth session #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/cross_signing
branch
from
1c1dd87
to
45b277f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1774 +/- ##
===========================================
+ Coverage 38.06% 38.11% +0.05%
===========================================
Files 616 616
Lines 97341 97383 +42
Branches 42016 42037 +21
===========================================
+ Hits 37054 37119 +65
+ Misses 59241 59215 -26
- Partials 1046 1049 +3
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
[MXRestClient authSessionForRequestWithMethod]is supposed to return an auth session which is then passed to crypto machine to setup cross-singing keys. It is however valid for the auth session to be empty, which is already accounted for inMXLegacyCrossSigning, but not inMXCrossSigningV2. This PR fixes that issue by behaving in the same way as legacy cross-signing, namely returning empty auth session instead of throwing an error.