Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing padded base64 instead of unpadded #1816

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Fix passing padded base64 instead of unpadded #1816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efa2888
Fix passing padded base64 instead of unpadded
BillCarsonFr Sep 8, 2023
96f7bc3
update changelog
BillCarsonFr Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MatrixSDK/Crypto/Verification/Transactions/QRCode/MXQRCodeTransactionV2.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class MXQRCodeTransactionV2: NSObject, MXQRCodeTransaction {
log.debug("->")

let data = MXQRCodeDataCoder().encode(otherQRCodeData)
let string = MXBase64Tools.base64(from: data)
let string = MXBase64Tools.unpaddedBase64(from: data)
guard let result = request.scanQrCode(data: string) else {
log.failure("Failed scanning QR code")
return
Expand Down
1 change: 1 addition & 0 deletions changelog.d/1816.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix | QR code verification failing due to incorrect encoding padding
Loading