Translations not supported #1309
Labels
Comments
|
It is supported, but there's some obvious gaps. We'll use this issue to track those. |
turt2live
changed the title
|
ah, I thought this was on riot-web. i18n is not supported at this level. |
turt2live
changed the title
|
I guess it's best to move these UI bits to riot-web or React SDK so they can be translated properly. As I understand, this repo is the network part of Riot, why does it set the room names based on the number of participants in it in the first place? Looks like a UI/UX part to me, not the protocol one. |
|
This isn't that low level. The js-sdk is more intended for client developers, which is why it has some of the spec's UI/UX features embedded into it. |
MadLittleMods
added a commit
to matrix-org/matrix-react-sdk
that referenced
this issue
Apr 3, 2023
See #10432 (comment) The HTTPError already has a good label and it isn't even translated if we re-label it here in this way generically Probably best to just remove in favor of thinking about a translations in general from the `matrix-js-sdk`, see matrix-org/matrix-js-sdk#1309
andybalaam
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this issue
Apr 14, 2023
* Properly translate errors in AddThreepid.ts Part of element-hq/element-web#9597 * Use translated message * Avoid returning undefined ever * More usage * Introduce UserFriendlyError * Use UserFriendlyError * Add more usage instead of normal error * Use types and translatedMessage * Fix lints * Update i18n although it's wrong * Use unknown for easier creation from try/catch * Use types * Use error types * Use types * Update i18n strings * Remove generic re-label of HTTPError See #10432 (comment) The HTTPError already has a good label and it isn't even translated if we re-label it here in this way generically Probably best to just remove in favor of thinking about a translations in general from the `matrix-js-sdk`, see matrix-org/matrix-js-sdk#1309 * Make error message extraction generic * Update i18n strings * Add tests for email addresses * More consistent error logging to actually see error in logs * Consistent error handling * Any is okay because we have a fallback * Check error type * Use dedicated mockResolvedValue function See #10432 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In particular, in Riot web the room name says "Empty room (was ..." when the other user leaves. This string can't be localized so it looks bad when everything else is in another language.
Related code:
matrix-js-sdk/src/models/room.js
Line 1910 in 84637c6
Same issue with
memberNamesToRoomNamefunction, it always sets the room name to "{user1} and {user2}" for a room with 3 participants regardless of the current locale.The text was updated successfully, but these errors were encountered: