Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Jest #1080

Merged
merged 6 commits into from
Nov 20, 2019
Merged

Switch to Jest #1080

merged 6 commits into from
Nov 20, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Nov 20, 2019

Ideally Lolex would also get dropped in exchange for jest fake timers but Lolex actually modifies built in Date unlike Jest so would require more refactoring.

  • Buildkite job needs renaming

Part of element-hq/element-web#11291

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team November 20, 2019 20:25
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good enough conversion

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy merged commit 2321b9a into develop Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants