Don't add ephemeral events to timeline when peeking #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As hopefully explained by comment. Fixes element-hq/element-web#11120
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jan 29, 2020
When the client loaded, we'd load the room view which would try to get a room object from the client, fail because the client wasn't ready, think it's because the user wasn't joined to the room and start peeking instead. Coupled with the bug fixed by matrix-org/matrix-js-sdk#1188 this would have caused element-hq/element-web#11120
turt2live
approved these changes
Jan 29, 2020
t3chguy
deleted the
dbkr/dont_add_epemeral_events_to_timeline_when_peeking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As hopefully explained by comment.
Fixes element-hq/element-web#11120