Dehydrate and rehydrate devices #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2020
uhoreg
changed the title
jryans
changed the title
jryans
requested changes
Sep 30, 2020
src/crypto/dehydration.ts
Outdated
| undefined, | ||
| { | ||
| device_data: deviceData, | ||
| // FIXME: initial device name? |
There was a problem hiding this comment.
I think we do need some kind of device name, or else do something special to handle it differently in the device list. It's quite perplexing to see a blank device in the device list. I'd suggest checking with Nad about this.
There was a problem hiding this comment.
(Have punted this to the react-sdk layer)
jryans
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on matrix-org/synapse#7955
implements matrix-org/matrix-spec-proposals#2697
relates to matrix-org/matrix-react-sdk#5239