Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript return types for membership update events #1739

Merged
merged 4 commits into from
Jun 24, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 16, 2021

Fixed some jsdoc and ts return types.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

src/client.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy force-pushed the t3chguy/fix/15051 branch from acd3cf9 to 7862fd9 Compare June 16, 2021 19:25
@t3chguy t3chguy requested a review from turt2live June 16, 2021 19:25
@t3chguy t3chguy changed the title Fix typescript return types and consolidate some code Fix typescript return types for membership update events Jun 16, 2021
…chguy/fix/15051

� Conflicts:
�	src/models/MSC3089TreeSpace.ts
@t3chguy t3chguy merged commit 4181799 into develop Jun 24, 2021
@t3chguy t3chguy deleted the t3chguy/fix/15051 branch June 24, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants