Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with /search and /context API handling for threads #2261

Merged
merged 8 commits into from
Mar 29, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 28, 2022

Fixes element-hq/element-web#21543


Here's what your changelog entry will look like:

🐛 Bug Fixes

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #2261 (8b962ac) into develop (c541b3f) will increase coverage by 0.64%.
The diff coverage is 76.11%.

@@             Coverage Diff             @@
##           develop    #2261      +/-   ##
===========================================
+ Coverage    58.34%   58.98%   +0.64%     
===========================================
  Files           91       91              
  Lines        16327    16346      +19     
  Branches      3764     3771       +7     
===========================================
+ Hits          9526     9642     +116     
+ Misses        6801     6704      -97     
Impacted Files Coverage Δ
src/models/thread.ts 62.20% <0.00%> (+19.34%) ⬆️
src/models/room.ts 54.24% <46.15%> (+1.25%) ⬆️
src/timeline-window.ts 90.68% <66.66%> (-0.06%) ⬇️
src/client.ts 38.48% <89.74%> (+1.81%) ⬆️
src/models/event-context.ts 70.00% <100.00%> (+70.00%) ⬆️
src/models/search-result.ts 100.00% <100.00%> (+100.00%) ⬆️
src/models/event-timeline-set.ts 77.99% <0.00%> (+0.77%) ⬆️
src/event-mapper.ts 100.00% <0.00%> (+4.54%) ⬆️
... and 3 more

@t3chguy t3chguy marked this pull request as ready for review March 28, 2022 16:27
@t3chguy t3chguy requested a review from a team as a code owner March 28, 2022 16:27
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, though there's a lot of formatting changes which make it a bit difficult to see what's going on. The timeline logic looks sane in the new diff at least.

@t3chguy t3chguy merged commit 85b8d4f into develop Mar 29, 2022
@t3chguy t3chguy deleted the t3chguy/fix/21502 branch March 29, 2022 08:24
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Apr 16, 2022
* Remove groups and groups-related APIs ([\matrix-org#2234](matrix-org#2234)).
* Add Element video room type ([\matrix-org#2273](matrix-org#2273)).
* Live location sharing - handle redacted beacons ([\matrix-org#2269](matrix-org#2269)).
* Fix getSessionsNeedingBackup() limit support ([\matrix-org#2270](matrix-org#2270)). Contributed by @adamvy.
* Fix issues with /search and /context API handling for threads ([\matrix-org#2261](matrix-org#2261)). Fixes element-hq/element-web#21543.
* Prevent exception 'Unable to set up secret storage' ([\matrix-org#2260](matrix-org#2260)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unable to load event" relating to threads
3 participants