Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline needs to refresh when we see a MSC2716 marker event #2299

Merged
merged 56 commits into from
Jun 1, 2022
Merged

Timeline needs to refresh when we see a MSC2716 marker event #2299

merged 56 commits into from
Jun 1, 2022

Commits on Apr 14, 2022

  1. Timeline needs to refresh when we see a MSC2716 marker event 

    > In a [sync meeting with @ara4n](https://docs.google.com/document/d/1KCEmpnGr4J-I8EeaVQ8QJZKBDu53ViI7V62y5BzfXr0/edit#bookmark=id.67nio1ka8znc), we came up with the idea to make the `marker` events as state events. When the client sees that the `m.room.marker` state changed to a different event ID, it can throw away all of the timeline and re-fetch as needed.
>
> For homeservers where the [same problem](matrix-org/matrix-spec-proposals#2716 (comment)) can happen, we probably don't want to throw away the whole timeline but it can go up the `unsigned.replaces_state` chain of the `m.room.marker` state events to get them all.
>
> In terms of state performance, there could be thousands of `marker` events in a room but it's no different than room members joining and leaving over and over like an IRC room.
>
> *-- matrix-org/matrix-spec-proposals#2716 (comment)
    @MadLittleMods
    MadLittleMods committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    d37fa81 View commit details
    Browse the repository at this point in the history

  2. Fix tests failing from function signature changes

    @MadLittleMods
    MadLittleMods committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    dbc7d66 View commit details
    Browse the repository at this point in the history

  3. Fix argument mismatch

    @MadLittleMods
    MadLittleMods committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    ee39d6c View commit details
    Browse the repository at this point in the history

  4. Add missing docstrings

    @MadLittleMods
    MadLittleMods committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    2468690 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2022

  1. Raw refreshLiveTimeline function that seems to work

    @MadLittleMods
    MadLittleMods committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    f44489d View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. Clean up raw commit

    @MadLittleMods
    MadLittleMods committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    1ab5460 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Remove event remitters 

    See matrix-org/matrix-react-sdk#8303 (comment)
    @MadLittleMods
    MadLittleMods committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    52ce184 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into madlittlemods/refresh-timeline-when-we-see-… 

    …msc2716-marker-events-v2
    @MadLittleMods
    MadLittleMods committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    d7c6802 View commit details
    Browse the repository at this point in the history

  3. Fix up lints

    @MadLittleMods
    MadLittleMods committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    26d4ecd View commit details
    Browse the repository at this point in the history

  4. Fix lints

    @MadLittleMods
    MadLittleMods committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    f1979d2 View commit details
    Browse the repository at this point in the history

  5. Use UnstableValue 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    c863ad1 View commit details
    Browse the repository at this point in the history

  6. Clarify toStartOfTimeline order 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    b58e198 View commit details
    Browse the repository at this point in the history

  7. Add backwards compatible overloads 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    81785ce View commit details
    Browse the repository at this point in the history

  8. Fix lints

    @MadLittleMods
    MadLittleMods committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    a98df62 View commit details
    Browse the repository at this point in the history

  9. Fix lints

    @MadLittleMods
    MadLittleMods committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    a8e4d07 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Match case of other events 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    d43a994 View commit details
    Browse the repository at this point in the history

  2. Add some missing type hints

    @MadLittleMods
    MadLittleMods committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    4acc712 View commit details
    Browse the repository at this point in the history

  3. Use built-in matches function 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    15d0e8a View commit details
    Browse the repository at this point in the history

  4. Add more missing types

    @MadLittleMods
    MadLittleMods committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    64a6e38 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Merge branch 'develop' into madlittlemods/refresh-timeline-when-we-see-… 

    …msc2716-marker-events-v2

Conflicts:
	spec/integ/matrix-client-syncing.spec.js
	spec/unit/room-state.spec.js
	src/models/room-state.ts
	src/models/room.ts
	src/sync.ts
    @MadLittleMods
    MadLittleMods committed May 19, 2022
    Configuration menu
    Copy the full SHA
    46f2933 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Add method to call MSC2716 /batch_send endpoint

    @MadLittleMods
    MadLittleMods committed May 20, 2022
    4 Configuration menu
    Copy the full SHA
    d267136 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Move batchSend to e2e test in matrix-react-sdk 

    See:

 - d267136#r74092517
 - matrix-org/matrix-react-sdk#8354 (comment)
    @MadLittleMods
    MadLittleMods committed May 24, 2022
    Configuration menu
    Copy the full SHA
    148434d View commit details
    Browse the repository at this point in the history

  2. Extra TimelineRefresh to make the timeline blank and have something t… 

    …o key off in the test but this also gives user feedback after pushing the refresh timeline button
    @MadLittleMods
    MadLittleMods committed May 24, 2022
    Configuration menu
    Copy the full SHA
    3973e34 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. getLatestTimeline for when no events exist in the timeline already

    @MadLittleMods
    MadLittleMods committed May 25, 2022
    Configuration menu
    Copy the full SHA
    a086489 View commit details
    Browse the repository at this point in the history

  2. Some cleanup

    @MadLittleMods
    MadLittleMods committed May 25, 2022
    Configuration menu
    Copy the full SHA
    d241f13 View commit details
    Browse the repository at this point in the history

  3. Fix lints

    @MadLittleMods
    MadLittleMods committed May 25, 2022
    Configuration menu
    Copy the full SHA
    0e3a5db View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into madlittlemods/refresh-timeline-when-we-see-… 

    …msc2716-marker-events-v2
    @MadLittleMods
    MadLittleMods committed May 25, 2022
    Configuration menu
    Copy the full SHA
    a19b075 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Better comment

    @MadLittleMods
    MadLittleMods committed May 26, 2022
    Configuration menu
    Copy the full SHA
    3dff724 View commit details
    Browse the repository at this point in the history

  2. Re-register state listeners after fixUpLegacyTimelineFields changes… 

    … the reference

Important so that you can refresh the timeline again after refreshing it once
    @MadLittleMods
    MadLittleMods committed May 26, 2022
    Configuration menu
    Copy the full SHA
    d37f788 View commit details
    Browse the repository at this point in the history

  3. Remove lastMarkerEventProcessed logic 

    I don't think it's necessary, #2299 (comment)
    @MadLittleMods
    MadLittleMods committed May 26, 2022
    Configuration menu
    Copy the full SHA
    6b8aa6c View commit details
    Browse the repository at this point in the history

  4. Add some missing test coverage 

    Added tests for the following

 - `getRoomCreator`
 - `getLatestTimeline`
 - `RoomEvent.OldStateUpdated` and `RoomEvent.CurrentStateUpdated`
    @MadLittleMods
    MadLittleMods committed May 26, 2022
    Configuration menu
    Copy the full SHA
    4bb1d14 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Add tests for sync state listeners and RoomEvent.CurrentStateUpdated

    @MadLittleMods
    MadLittleMods committed May 27, 2022
    Configuration menu
    Copy the full SHA
    34a943b View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @MadLittleMods
    MadLittleMods committed May 27, 2022
    Configuration menu
    Copy the full SHA
    e412aa1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into madlittlemods/refresh-timeline-when-we-see-… 

    …msc2716-marker-events-v2
    @MadLittleMods
    MadLittleMods committed May 27, 2022
    Configuration menu
    Copy the full SHA
    7a90629 View commit details
    Browse the repository at this point in the history

  4. Fix test when we only emit on reference change

    @MadLittleMods
    MadLittleMods committed May 27, 2022
    Configuration menu
    Copy the full SHA
    9d1c7c7 View commit details
    Browse the repository at this point in the history

  5. Fix test passing with and without timelineSupport

    @MadLittleMods
    MadLittleMods committed May 27, 2022
    Configuration menu
    Copy the full SHA
    c36e1b9 View commit details
    Browse the repository at this point in the history

  6. Consolidate imports

    @MadLittleMods
    MadLittleMods committed May 27, 2022
    Configuration menu
    Copy the full SHA
    f663d6b View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary overloads for private method 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed May 27, 2022
    Configuration menu
    Copy the full SHA
    313df51 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2022

  1. Add barebones tests for overloads 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed May 28, 2022
    Configuration menu
    Copy the full SHA
    90db6fd View commit details
    Browse the repository at this point in the history

  2. More straight-forward if-else 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed May 28, 2022
    Configuration menu
    Copy the full SHA
    9f3df87 View commit details
    Browse the repository at this point in the history

  3. Added extra explanation what marker event means 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed May 28, 2022
    Configuration menu
    Copy the full SHA
    8fc837f View commit details
    Browse the repository at this point in the history

  4. Fix lint

    @MadLittleMods
    MadLittleMods committed May 28, 2022
    Configuration menu
    Copy the full SHA
    78689a9 View commit details
    Browse the repository at this point in the history

  5. Dry interfaces by extending (OOP) 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed May 28, 2022
    Configuration menu
    Copy the full SHA
    58fa63c View commit details
    Browse the repository at this point in the history

  6. Use Pick<> to be more composable and obvious what we're extending 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed May 28, 2022
    Configuration menu
    Copy the full SHA
    d0466a1 View commit details
    Browse the repository at this point in the history

  7. Use optional chaining and null coalescing for more accurate and stand… 

    …ard code

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
    @MadLittleMods @t3chguy
    MadLittleMods and t3chguy authored May 28, 2022
    Configuration menu
    Copy the full SHA
    e67b620 View commit details
    Browse the repository at this point in the history

  8. Add type

    @MadLittleMods
    MadLittleMods committed May 28, 2022
    Configuration menu
    Copy the full SHA
    2a4a430 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Add deprecation warnings for old overloads 

    See #2299 (comment)

 - Move the preferred overload to the top so it's suggested first
 - Add `@deprecated` decorators to the deprecated overload
 - Add deprecation log warning when we see usage of the deprecated function
    @MadLittleMods
    MadLittleMods committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    e4bd518 View commit details
    Browse the repository at this point in the history

  2. Better test name

    @MadLittleMods
    MadLittleMods committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    310423a View commit details
    Browse the repository at this point in the history

  3. Add refresh timeline tests to matrix-js-sdk 

    See #2299 (comment)
    @MadLittleMods
    MadLittleMods committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    ac07eaf View commit details
    Browse the repository at this point in the history

  4. WIP: almost working perfect merge test

    @MadLittleMods
    MadLittleMods committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4915aef View commit details
    Browse the repository at this point in the history

  5. Working tests

    @MadLittleMods
    MadLittleMods committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    460e887 View commit details
    Browse the repository at this point in the history

  6. Fix lints

    @MadLittleMods
    MadLittleMods committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    741a4fa View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into madlittlemods/refresh-timeline-when-we-see-… 

    …msc2716-marker-events-v2
    @t3chguy
    t3chguy authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a33de28 View commit details
    Browse the repository at this point in the history

  8. Accurate return description 

    Previously copy-paste from `client.getEventTimeline()`
    @MadLittleMods
    MadLittleMods authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    2bda3d3 View commit details
    Browse the repository at this point in the history

  9. Correct function parameters 

    Previously copy-paste from `client.getEventTimeline()`
    @MadLittleMods
    MadLittleMods authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    150a498 View commit details
    Browse the repository at this point in the history

  10. Small formatting updates

    @MadLittleMods
    MadLittleMods authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a5f832f View commit details
    Browse the repository at this point in the history