Helper to help components spit out debug logs #2349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
commented
May 5, 2022
MadLittleMods
commented
May 5, 2022
t3chguy
reviewed
May 5, 2022
Comment on lines
+8969
to
+8972
| public dumpDebugLogs() { | ||
| logger.debug('matrix-js-sdk: dumping extra debug logs to the console'); | ||
| this.emit(ClientEvent.DumpDebugLogs); | ||
| } |
There was a problem hiding this comment.
using logs is a really bad mechanism given that it relies on consumers monkey-patching console which we don't say anywhere in the generated docs to do
There was a problem hiding this comment.
This doesn't have to live in matrix-js-sdk. What event emitter pattern can we use exclusively in matrix-react-sdk? This point is tracked by matrix-org/matrix-react-sdk#8502 (comment)
MadLittleMods
changed the title
turt2live
requested changes
May 5, 2022
turt2live
requested changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper to help components spit out debug logs
Part of matrix-org/matrix-react-sdk#8502
This change is marked as an internal change (Task), so will not be included in the changelog.