Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More sonar tweaks and typing improvements #2366

Merged
merged 10 commits into from
May 13, 2022
Merged

More sonar tweaks and typing improvements #2366

merged 10 commits into from
May 13, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 13, 2022 •
edited by github-actions bot
Loading

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label May 13, 2022
@t3chguy t3chguy marked this pull request as ready for review May 13, 2022 09:45
@t3chguy t3chguy requested a review from a team as a code owner May 13, 2022 09:45
@t3chguy t3chguy removed the Easy label May 13, 2022
turt2live
turt2live approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm generally

src/client.ts Show resolved Hide resolved
@t3chguy t3chguy enabled auto-merge (squash) May 13, 2022 18:01
@t3chguy t3chguy merged commit 7201334 into develop May 13, 2022
@t3chguy t3chguy deleted the t3chguy/sonar-pass22 branch May 13, 2022 18:08
@t3chguy t3chguy mentioned this pull request May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @turt2live