Ensure rooms are recalculated on re-invites #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
force-pushed
the
travis/room-list/fix-invite-archive-invite
branch
from
d056d14 to
5ea0ed1
Compare
t3chguy
approved these changes
May 17, 2022
| @@ -1166,6 +1166,9 @@ export class SyncApi { | |||
| room.recalculate(); | |||
| client.store.storeRoom(room); | |||
| client.emit(ClientEvent.Room, room); | |||
| } else { | |||
| // Update room state for invite->reject->invite cycles | |||
| room.recalculate(); | |||
There was a problem hiding this comment.
Can we not just move the recalculate out to before the if?
There was a problem hiding this comment.
We can, but then the comment is less clear imo
|
Slightly worried about this change: if people notice performance regressions, please flag. |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Jun 7, 2022
* Convert `getLocalAliases` to a stable API call ([\matrix-org#2402](matrix-org#2402)). * Fix request, crypto, and bs58 imports ([\matrix-org#2414](matrix-org#2414)). Fixes matrix-org#2415. * Update relations after every decryption attempt ([\matrix-org#2387](matrix-org#2387)). Fixes element-hq/element-web#22258. Contributed by @weeman1337. * Fix degraded mode for the IDBStore and test it ([\matrix-org#2400](matrix-org#2400)). Fixes matrix-org/element-web-rageshakes#13170. * Don't cancel SAS verifications if `ready` is received after `start` ([\matrix-org#2250](matrix-org#2250)). * Prevent overlapping sync accumulator persists ([\matrix-org#2392](matrix-org#2392)). Fixes vector-im/element-web#21541. * Fix behaviour of isRelation with relation m.replace for state events ([\matrix-org#2389](matrix-org#2389)). Fixes element-hq/element-web#22280. * Fixes matrix-org#2384 ([\matrix-org#2385](matrix-org#2385)). Fixes undefined/matrix-js-sdk#2384. Contributed by @schmop. * Ensure rooms are recalculated on re-invites ([\matrix-org#2374](matrix-org#2374)). Fixes element-hq/element-web#22106.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#22106
Reviewer: This has two commits: a failing test and the fix. This is to demonstrate that the test actually works, because I don't exactly have confidence in it myself.
Here's what your changelog entry will look like:
🐛 Bug Fixes