Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notification type when resetting threads notifications #2757

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Fix notification type when resetting threads notifications #2757

merged 4 commits into from
Oct 17, 2022

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Oct 14, 2022 •
edited by github-actions bot
Loading

For element-hq/element-web#23192

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg added the T-Task Tasks for the team like planning label Oct 14, 2022
@germain-gg germain-gg requested a review from a team as a code owner October 14, 2022 14:23
turt2live
turt2live approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though the strict error checker appears to be catching a legit bug?

@germain-gg germain-gg merged commit be11fa6 into develop Oct 17, 2022
@germain-gg germain-gg deleted the gsouquet/notifications-msc3773 branch October 17, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

@weeman1337 weeman1337 Awaiting requested review from weeman1337 weeman1337 is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germain-gg @turt2live