Remove brokenheaded encryption test #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test seemed to be testing the behaviour of decrypting redacted events, but that seems... strange. A redaction event cannot be encrypted (at least, there is no spec for it), and it should be impossible to decrypt a (correctly) redacted event, because such an event will lack a `ciphertext` property. This test is just sticking a "redacted_because" property into a regular event, which is a bit of a nonsense.
t3chguy
approved these changes
Jan 17, 2023
|
For links: the test was added in #2531. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test seemed to be testing the behaviour of decrypting redacted events, but
that seems... strange. A redaction event cannot be encrypted (at least, there
is no spec for it), and it should be impossible to decrypt a (correctly)
redacted event, because such an event will lack a
ciphertextproperty.This test is just sticking a "redacted_because" property into a regular event,
which is a bit of a nonsense.
This change is marked as an internal change (Task), so will not be included in the changelog.