Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add easy way to determine if the decryption failure is due to "DecryptionError: The sender has disabled encrypting to unverified devices." #3167

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Add easy way to determine if the decryption failure is due to "DecryptionError: The sender has disabled encrypting to unverified devices." #3167

merged 7 commits into from
Feb 21, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Feb 21, 2023 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

  • Add easy way to determine if the decryption failure is due to "DecryptionError: The sender has disabled encrypting to unverified devices." (#3167). Contributed by @florianduros.

@florianduros florianduros marked this pull request as ready for review February 21, 2023 10:17
@florianduros florianduros requested a review from a team as a code owner February 21, 2023 10:17
@florianduros florianduros mentioned this pull request Feb 21, 2023
Merged
3 tasks
t3chguy
t3chguy reviewed Feb 21, 2023
View reviewed changes
src/models/event.ts Outdated Show resolved Hide resolved
t3chguy
t3chguy reviewed Feb 21, 2023
View reviewed changes
src/models/event.ts Outdated Show resolved Hide resolved
@florianduros florianduros added this pull request to the merge queue Feb 21, 2023
t3chguy
t3chguy reviewed Feb 21, 2023
View reviewed changes
src/models/event.ts Outdated Show resolved Hide resolved
@florianduros florianduros removed this pull request from the merge queue due to a manual request Feb 21, 2023
@florianduros florianduros added this pull request to the merge queue Feb 21, 2023
Merged via the queue into develop with commit 1f0c6a6 Feb 21, 2023
@florianduros florianduros deleted the florianduros/feat/add-reason-to-event branch February 21, 2023 16:33
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Mar 15, 2023
@su-ex
Merge tag 'v23.4.0' into sc
0c0854b 
* Add easy way to determine if the decryption failure is due to "DecryptionError: The sender has disabled encrypting to unverified devices." ([\matrix-org#3167](matrix-org#3167)). Contributed by @florianduros.
* Polls: expose end event id on poll model ([\matrix-org#3160](matrix-org#3160)). Contributed by @kerryarchibald.
* Polls: count undecryptable poll relations ([\matrix-org#3163](matrix-org#3163)). Contributed by @kerryarchibald.
* Fix spec compliance issue around encrypted `m.relates_to` ([\matrix-org#3178](matrix-org#3178)).
* Fix reactions in threads sometimes causing stuck notifications ([\matrix-org#3146](matrix-org#3146)). Fixes element-hq/element-web#24000. Contributed by @justjanne.
* Better type guard parseTopicContent ([\matrix-org#3165](matrix-org#3165)). Fixes matrix-org/element-web-rageshakes#20177 and matrix-org/element-web-rageshakes#20178.
* Fix a bug where events in encrypted rooms would sometimes erroneously increment the total unread counter after being processed locally. ([\matrix-org#3130](matrix-org#3130)). Fixes element-hq/element-web#24448. Contributed by @Half-Shot.
* Stop the ICE disconnected timer on call terminate ([\matrix-org#3147](matrix-org#3147)).
* Clear notifications when we can infer read status from receipts ([\matrix-org#3139](matrix-org#3139)). Fixes element-hq/element-web#23991.
* Messages sent out of order after one message fails ([\matrix-org#3131](matrix-org#3131)). Fixes element-hq/element-web#22885 and element-hq/element-web#18942. Contributed by @justjanne.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy left review comments

@artcodespace artcodespace artcodespace approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianduros @t3chguy @artcodespace