Implement MSC3758: a push rule condition to match event properties exactly #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
exact-event-match
branch
from
8912aca
to
db18338
Compare
3 tasks
clokep
force-pushed
the
exact-event-match
branch
from
db18338
to
42560aa
Compare
clokep
changed the title
florianduros
approved these changes
Mar 1, 2023
|
Something in this seems to be conflicting with #3181 -- tests are failing when I merge in |
3 tasks
|
This can now get merged as MSC3758 has passed FCP! 🎉 |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Mar 15, 2023
* Implement MSC3758: a push rule condition to match event properties exactly ([\matrix-org#3179](matrix-org#3179)). * Enable group calls without video and audio track by configuration of MatrixClient ([\matrix-org#3162](matrix-org#3162)). Contributed by @EnricoSchw. * Updates to protocol used for Sign in with QR code ([\matrix-org#3155](matrix-org#3155)). Contributed by @hughns. * Implement MSC3873 to handle escaped dots in push rule keys ([\matrix-org#3134](matrix-org#3134)). Fixes undefined/matrix-js-sdk#1454. * Fix spec compliance issue around encrypted `m.relates_to` ([\matrix-org#3178](matrix-org#3178)). * Fix reactions in threads sometimes causing stuck notifications ([\matrix-org#3146](matrix-org#3146)). Fixes element-hq/element-web#24000. Contributed by @justjanne.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the stable version of MSC3758 -- a new push rule condition to match an event property exactly (instead of globbing).
MSC3758 is in the final comment period, but not yet merged. We must wait until it finishes FCP before merging.
This is currently based on #3134, I'll rebase once that is merged.Checklist
Sign-off given on the changes (see CONTRIBUTING.md)Here's what your changelog entry will look like:
✨ Features